Add Environment and Project IDs to controller builds #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block as not needed anymore
… make sure build jobs send the environment id when they are created (tasks do already)
|
Just FYI, there is no issue releasing this before the controller is updated as it will fall back to the original behaviour. Once the controller gets updated, then it will use the ID values properly. |
shreddedbacon
added
2-build-deploy
tobybellwood
pushed a commit
that referenced
this pull request
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Somewhat related to #2322, Lagoon sends a DNS compliant version of the environment name to the build deploy controller. When a build is completed, it responds to Lagoon with this modified environment name. In the event that the original environment name contained slashes or other special characters, Lagoon would not actually update the API with the information required.
Lagoon will prefer to use the environment ID if it is present, but will fall back to using the environment name if no ID is found.
This is a partner to uselagoon/remote-controller#41 , which adds the support for these IDs into the build deploy controller.
Closes
closed #2568