Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task File Upload broken since node16 upgrade #2746

Closed
Schnitzel opened this issue Jul 1, 2021 · 0 comments · Fixed by #2747
Closed

Task File Upload broken since node16 upgrade #2746

Schnitzel opened this issue Jul 1, 2021 · 0 comments · Fixed by #2747
Labels
1-api-auth API & Authentication subsystem
Milestone
v2.0.0

Comments

@Schnitzel
Copy link
Contributor

since we upgraded to node16 the Task File Upload is broken.
@rocketeerbkw and I looked into this and it's some strange change in Node 13 around File Streams and graphql-upload (jaydenseric/graphql-upload#170)
@Schnitzel Schnitzel added the 1-api-auth API & Authentication subsystem label Jul 1, 2021
@Schnitzel Schnitzel added this to the v2.0.0 milestone Jul 1, 2021
Schnitzel added a commit that referenced this issue Jul 1, 2021
@Schnitzel
#2746 fix broken file upload with a workaround:
8c78749 
Somehow the returned readStream from graphql-upload is not a proper readStream anymore and the AWS SDK doesn't like it and just gets stuck.
Recreating a new readStream from the path solves this
Schnitzel added a commit that referenced this issue Jul 1, 2021
@Schnitzel
#2746 fix broken file upload with a workaround:
bd1854b 
Somehow the returned readStream from graphql-upload is not a proper readStream anymore and the AWS SDK doesn't like it and just gets stuck.
Recreating a new readStream from the path solves this
@Schnitzel Schnitzel mentioned this issue Jul 1, 2021
Merged
Schnitzel added a commit that referenced this issue Jul 2, 2021
@Schnitzel
Merge pull request #2747 from uselagoon/2746-broken-task-file-upload
8252dbe 
#2746 fix broken file upload with a workaround:
@smlx smlx mentioned this issue Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

#2746 fix broken file upload with a workaround: uselagoon/lagoon
1 participant
@Schnitzel