Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route generation takes a LONG time for environments with many routes #3118

Closed
cdchris12 opened this issue Apr 19, 2022 · 3 comments
Closed
Labels
2-build-deploy Build & Deploy subsystem

Comments

@cdchris12
Copy link
Contributor

Describe the bug

After updating an Openshift cluster to using the v2.5.0 version kubectl-build-deploy-dind image from a much older version of this image, it was noticed that a specific project with multiple hundreds of routes was now taking multiple hours to build, where it took ~20 minutes previously. The overwhelming majority of this time is spent with the build pod sitting at ~100% CPU usage (1 core) churning through executing the exec-routes-generation.sh script.

To Reproduce

Steps to reproduce the behavior:

  1. Create an example project with multiple hundred routes in its .lagoon.yml
  2. Deploy the project
  3. See build take multiple hours
  4. ????
  5. PROFIT

Expected behavior

Deployments should not take multiple hours, regardless of the number of domains present in a project/environment.

Screenshots

N/A

Additional context

Given the massive amounts of domains in this project, it seems to me that what we're seeing here is simply handling/processing a substantial amount of data numerous times. I would assume it would be better to store this data somehow once accessed, so that we don't need to read the .lagoon.yml file, pipe that to shyaml, then filter for the specific bit we need; multiple times. Maybe this routes generation activity is better suited to a higher programming language like Python?

@cdchris12 cdchris12 added the 2-build-deploy Build & Deploy subsystem label Apr 19, 2022
@seanhamlin
Copy link
Contributor

This is fixed by #3133 right?

@cdchris12
Copy link
Contributor Author

This would've been resolved by #3133, but that functionality was reverted as part of the work done in #3181 to resolve issues we saw with badly formatted docker-compose.yml files. For now, this issue remains unresolved as of Lagoon release 2.8.4

@shreddedbacon
Copy link
Member

This has been fixed now that routes are handled in the build-deploy-tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-build-deploy Build & Deploy subsystem
Projects
None yet
Development

No branches or pull requests

3 participants