Renamed the variable to VARNISH_SET_HEADER_CACHE_TAGS #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasrecht
deleted the
1049-rename-variable-VARNISH_UNSET_HEADER_CACHE_TAGS
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
The
default.vclfile has anifstatement where the name of the variable (VARNISH_UNSET_HEADER_CACHE_TAGS) implies to disable a feature, while if set totrueit does the opposite.I renamed the variable in VARNISH_SET_HEADER_CACHE_TAGS, kept the default value to
false, so feature is NOT enabled by default.Changelog Entry
Bugfix - Renamed the VARNISH_UNSET_HEADER_CACHE_TAGS variable to VARNISH_SET_HEADER_CACHE_TAGS (#1049)
Closing issues
closes #1049