Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some ansible warnings in test suite #1520

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Fix some ansible warnings in test suite #1520

merged 1 commit into from
Jan 13, 2020

Conversation

smlx
Copy link
Member

@smlx smlx commented Jan 3, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This PR updates parts of the test suite that were generating ansible warnings like this in the test output:

[WARNING]: when statements should not include jinja2 templating delimiters

Changelog Entry

Improvement - Avoid ansible warnings in CI

Closing issues

n/a

@smlx
Copy link
Member Author

smlx commented Jan 3, 2020

Build is broken pending #1517

@tobybellwood tobybellwood added the 6-images-testing Base Images & Testing subsystem label Jan 3, 2020
tobybellwood
tobybellwood approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - less jinja whinging FTW

@smlx smlx mentioned this pull request Jan 13, 2020
Closed
3 tasks
@Schnitzel Schnitzel merged commit 1513c1f into master Jan 13, 2020
@Schnitzel Schnitzel added this to the v1.3.0 milestone Jan 13, 2020
@smlx smlx deleted the ansible-warnings branch January 20, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smlx @tobybellwood @Schnitzel