New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul router log handling #1570
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The effective version of the previous build-dep was 7.3
Simplify the build by reusing the same variable name.
* use BASE_VERSION * add versions to pecl extensions, as recommended upstream
Also remove recursive make from minishift and add minishift/start target.
Remove logic from Makefile as well as build/ directory and associated .gitignore entries.
Use dependencies to avoid recursive make.
* use bare keycloak service name in docker-compose.yaml where possible * make keycloak service name configurable where necessary * configure the keycloak service URL in the `make up` target on linux
Avoid .1 as that is the host gateway.
Minishift can be slow, so bump the number of retries to give it more time to update routes.
This service intercepts router logs from openshift and copies them to both the old and the new router log collector.
This service takes router logs, parses them, and sends them to the broker.
This services collects logs from the broker and sends them to the logs-db.
This is required for the router logs test suite.
The compose file to use can be targeted via the `up` Makefile target: make up COMPOSE_FILE=docker-compose.logs.yaml
This is partially superseded by #1859. I'll close this one, maybe some bits will make it into another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This change implements the router logs part of the logging infrastructure rebuild (#1297).
It introduces three new services:
logs-tee
listens for remote syslog UDP packets, and forwards them to 2 (or more) destinations.This is designed to allow the new router logging system to be deployed alongside the existing system until it has been tested in production. Then eventually the existing system can be removed.
router-logs-collector
takes remote syslog, converts it to JSON format and forwards it to a rabbitMQ exchange.logs-dispatcher
takes logs from a rabbitMQ queue in batches and sends it to an elasticsearch index.Here's the route that router logs now take:
The key changes from the existing router log infrastructure is:
The aim of this is to improve Elasticsearch performance by reducing the number of indices.
This relies on kubernetes namespace labelling with
lagoon/project: <projectname>
, which is read by fluentd during log parsing.This PR doesn't include
.lagoon.yml
, because I'm not sure how to test that locally.It does include integration tests for the new components. You can run them locally:
Note that this PR builds on top of #1428, and includes #1526, #1489, #1566, #1569, #1542 which have been split out for easier review.
The easiest diff for changes in this PR is auto-build-system...logs-overhaul
Closing issues
Partially implements #1364
Closes #1298, #674
Relates to #1297, #1164, #1454, #1146