Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Makefile fixes #1780

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Minor Makefile fixes #1780

merged 1 commit into from
Apr 8, 2020

Conversation

smlx
Copy link
Member

@smlx smlx commented Apr 8, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Update a couple of missing/wrong .PHONY targets and add a missing minishift dependency.

Closing issues

n/a

@smlx smlx added the 2-build-deploy Build & Deploy subsystem label Apr 8, 2020
@Schnitzel Schnitzel added this to the v1.4.1 milestone Apr 8, 2020
@Schnitzel Schnitzel merged commit 2fc819b into master Apr 8, 2020
@tobybellwood tobybellwood added 6-images-testing Base Images & Testing subsystem and removed 2-build-deploy Build & Deploy subsystem labels Apr 8, 2020
@smlx smlx deleted the minor-makefile-fixes branch April 30, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schnitzel Schnitzel Awaiting requested review from Schnitzel

@shreddedbacon shreddedbacon Awaiting requested review from shreddedbacon

Assignees
No one assigned
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smlx @Schnitzel @tobybellwood