Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix favicon URL typo #1790

Merged
merged 1 commit into from
May 7, 2020
Merged

Fix favicon URL typo #1790

merged 1 commit into from
May 7, 2020

Conversation

smlx
Copy link
Member

@smlx smlx commented Apr 14, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

This PR fixes a 404 and missing favicon in lagoon dashboard. Possibly only on non-apple devices?

Closing issues

n/a

@smlx smlx added the 1-api-auth API & Authentication subsystem label Apr 14, 2020
@seanhamlin seanhamlin added the ui label Apr 14, 2020
@seanhamlin
Copy link
Contributor

Nice spotting @smlx !

@rocketeerbkw rocketeerbkw added this to the v1.5.0 milestone Apr 23, 2020
@Schnitzel Schnitzel merged commit bea89af into master May 7, 2020
@smlx smlx deleted the fix-favicon-404 branch May 8, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanhamlin seanhamlin seanhamlin approved these changes

Assignees
No one assigned
Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smlx @seanhamlin @rocketeerbkw @Schnitzel