Destructive Action Button Color #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketeerbkw
requested changes
Apr 16, 2020
There was a problem hiding this comment.
A whole new component for a delete button feels wrong. The two buttons have the same functionality just with different colors.
I don't know what the "standard" is but material design, for example, uses variant and color to control styling. I think here we can add a color prop that defaults to blue and can accept red.
Also, there is another delete button in the billing modifiers
|
@rocketeerbkw I've added |
rocketeerbkw
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Destructive actions are currently blue, friendly looking buttons. They should not be blue.
Closing issues
closes #1748