Add Harbor Migration Script #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Get project's env vars | ||
| var envVars = await query(sqlClient, `SELECT * FROM env_vars WHERE project='${project.id}';`); | ||
| var hasVars = false; | ||
| if (envVars != null) { |
There was a problem hiding this comment.
Did you test this specific condition? Our sql library is weird and I don't remember if returning 0 results actually returns null or if the != is coercing the actual result (I think an object?) to null and so it's true by accident.
There was a problem hiding this comment.
Good catch; this was an artifact from my earlier testing attempts. I removed this logic, and the script still functions as intended.
rocketeerbkw
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script which can be used to create Harbor projects, create Harbor robot accounts, and add the corresponding environment variables to a project which does not currently have a Harbor project associated with it.
Checklist