Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.js v14 images #1810

Merged
merged 1 commit into from
May 7, 2020
Merged

Add Node.js v14 images #1810

merged 1 commit into from
May 7, 2020

Conversation

rocketeerbkw
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Node.js v14 LTS was released today, this adds images for that version.

Closing issues

closes #1712

@seanhamlin seanhamlin added the 6-images-testing Base Images & Testing subsystem label Apr 22, 2020
smlx
smlx approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Schnitzel Schnitzel merged commit 8940778 into master May 7, 2020
@rocketeerbkw rocketeerbkw deleted the node_14 branch June 22, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlx smlx smlx approved these changes

Assignees
No one assigned
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Base Images for NodeJS 14
4 participants
@rocketeerbkw @smlx @Schnitzel @seanhamlin