Re-implement JWT generation script using pyjwt #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we have 3 other places where we generate jwts in bash: https://github.com/amazeeio/lagoon/blob/lagoon.sh-prefix/local-dev/api-data-watcher-pusher/create_jwt.sh they all install nodejs to use jwtgen |
smlx
commented
May 8, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I was cleaning up local branches and came across this patch.. I thought I already submitted a PR months ago but I guess not. I think this was from AIOSEC-3.
This is a rewrite of the token generation script in python instead of bash. The advantage is that it makes the script much easier to understand and takes advantage of a widely used library (https://github.com/jpadilla/pyjwt).
Closing issues
n/a