Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit k3d cluster name length #1832

Merged
merged 2 commits into from
May 3, 2020
Merged

Limit k3d cluster name length #1832

merged 2 commits into from
May 3, 2020

Conversation

smlx
Copy link
Member

@smlx smlx commented May 1, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

This PR limits the length of the k3d cluster name to 35 characters to avoid error messages like this:

time="2020-04-30T14:57:46+02:00" level=fatal msg="Cluster name is too long (37 > 35)"
Makefile:1009: recipe for target 'k3d' failed
make: *** [k3d] Error 1

Characters are removed from the front of the CI_BUILD_TAG to get down to 35 chars so that the incrementing CI build number at the end of CI_BUILD_TAG is retained in the cluster name. This way the name remains unique.

I also removed an unused Makefile variable.

Closing issues

n/a

@smlx smlx added the 6-images-testing Base Images & Testing subsystem label May 1, 2020
@Schnitzel Schnitzel merged commit d9ed9e7 into master May 3, 2020
@Schnitzel Schnitzel added this to the v1.5.0 milestone May 3, 2020
@smlx smlx deleted the remove-testparameter branch May 5, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants