Fix notification of error message to rocketchat/slack #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schnitzel
requested changes
Jun 23, 2020
Added DEBUG option Changed how PROJECTNAME variable is get
|
@Schnitzel can you have a review? |
Schnitzel
requested changes
Jul 1, 2020
There was a problem hiding this comment.
hey @vincenzodnp
good work! but some more things needed to make the script more robust and better to understand.
also can you run another shellcheck over it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
check_acme_routes.shscript's notification of error message in slack/rocketchatChecklist
Closing issues
closes #1971