Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging GitBook Branch! #2219

Merged
merged 135 commits into from
Sep 29, 2020
Merged

Merging GitBook Branch! #2219

merged 135 commits into from
Sep 29, 2020

Conversation

AlannaBurke
Copy link
Contributor

This PR merges all changes that have been made to documentation since forking off the repo to work on GitBook. The only changes should be to documentation. Some structure was changed inside of the docs/ directory but that should be sorted here.

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial q's

@@ -1,24 +0,0 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I think GitBook might have run amok here, I'll clean it up.

@@ -1,26 +0,0 @@
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise, do we need to remove this file?

.gitmodules Outdated
@@ -0,0 +1,3 @@
[submodule "documentation"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was my ill-fated attempt to get this working with sub-modules, thanks for catching this, I thought I'd deleted it.

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this!!!

@AlannaBurke AlannaBurke merged commit 035b4cc into uselagoon:main Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants