Use new nginx-ingress stable location #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlx
reviewed
Nov 17, 2020
| echo "$(K3D_NAME)" > $@ | ||
| export KUBECONFIG="$$(./local-dev/k3d get-kubeconfig --name='$(K3D_NAME)')"; \ | ||
| local-dev/kubectl --kubeconfig="$$(./local-dev/k3d get-kubeconfig --name='$(K3D_NAME)')" apply -f $$PWD/local-dev/k3d-storageclass-bulk.yaml; \ | ||
| docker tag $(CI_BUILD_TAG)/docker-host localhost:5000/lagoon/docker-host; \ | ||
| docker push localhost:5000/lagoon/docker-host; \ | ||
| local-dev/kubectl --kubeconfig="$$(./local-dev/k3d get-kubeconfig --name='$(K3D_NAME)')" --context='$(K3D_NAME)' create namespace nginx-ingress; \ |
There was a problem hiding this comment.
helm upgrade takes a --create-namespace argument that does this, might be easier?
There was a problem hiding this comment.
I'm not fussed. I just copy pasta'd one of the ones below and renamed things.
Don't know how long this will hang around for if we are moving off the deprecated one in the future anyway?
There was a problem hiding this comment.
ah sorry missed that. since the other commands use that approach never mind
smlx
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
As per https://helm.sh/blog/new-location-stable-incubator-charts/ the helm stable chart location changed, and on november 13 became unusable. This prevent the
stable/nginx-ingressbeing installed like it normally does.This just installs it like other charts we already install as part of testing but uses the new chart location specifically.