Active standby fixes #2361
Merged
Active standby fixes #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Lagoon-charts was updated recently to install dioscuri, this meant that two versions of dioscuri were running and competing for the task.
This PR updates the makefile so that lagoon-remote doesn't install dioscuri.
Dioscuri was also updated to do things slightly differently for when the ingress-nginx admission webhook comes into play, so this PR has references to that branches chart, once confirmed that the tests pass here amazeeio/dioscuri#11 will need to be merged and this PR updated again to use
mainchart instead ofadmissionfixAdditional changes were made to the active/standby tasks in
kubernetesmiscandopenshiftmiscto increase the timeout to 60s as sometimes the task could take slightly longer than the original timeout. This timeout isn't a problem when moving to use the lagoon builddeploy controllers though.Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).