Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local dev DX improvements and bugfixes #2643

Merged
merged 3 commits into from May 27, 2021
Merged

Local dev DX improvements and bugfixes #2643

merged 3 commits into from May 27, 2021

Conversation

rocketeerbkw
Copy link
Member

@rocketeerbkw rocketeerbkw commented May 10, 2021 •
edited

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Some misc issues I've noticed while developing locally

  • Don't leave running containers after a 'make kind/clean'
  • Fix emoji in branch names breaking jenkins
  • Fix UI test data that tries to actually run

Closing issues

n/a

@rocketeerbkw rocketeerbkw changed the title Some small DX improvements to Makefile Local dev DX improvements and bugfixes May 20, 2021
@rocketeerbkw rocketeerbkw marked this pull request as ready for review May 26, 2021 21:48
@rocketeerbkw rocketeerbkw added the 6-images-testing Base Images & Testing subsystem label May 26, 2021
@tobybellwood tobybellwood merged commit 8284bac into main May 27, 2021
@tobybellwood tobybellwood deleted the rocketeerbkw-patch-1 branch May 27, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rocketeerbkw @tobybellwood