Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fact api changes for fact search #2693

Merged
merged 15 commits into from Aug 19, 2021
Merged

Conversation

timclifford
Copy link
Contributor

@timclifford timclifford commented Jun 4, 2021

Checklist

Main changes to api

  • adds new fact search query that returns projects/environments via getProjectsByFactSearch and getEnvironmentsByFactSearch resolvers. These are available as projectsByMetadata and environmentsByFactSearch
  • adds 'fact_reference' field which will allow for better fact categorisation
  • adds concept of 'key' facts so we can give priority to particular facts
  • updates 'knex" to v0.95

Closing issues

closes #2483

@timclifford timclifford changed the base branch from release/facts to main June 4, 2021 11:33
@timclifford timclifford force-pushed the feature/facts-search-api-changes branch from 8d191e0 to d0daa6f Compare June 4, 2021 11:44
@bomoko
Copy link
Contributor

bomoko commented Jun 29, 2021

I think it would be good to get @rocketeerbkw's eyes on on this too. We're adding a bit to the API and making permission changes.

@tobybellwood tobybellwood added this to the v2.0.0-rc.9 milestone Aug 18, 2021
@bomoko bomoko merged commit a30dddb into main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types for Facts
3 participants