Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding check for double dashes in new project names #2785

Merged
merged 1 commit into from Aug 20, 2021
Merged

Adding check for double dashes in new project names #2785

merged 1 commit into from Aug 20, 2021

Conversation

cdchris12
Copy link
Contributor

This PR adds a check for -- in any new Lagoon project's name, which will cause the process to fail if this string is found.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Closing issues

Closes #2783

@cdchris12 cdchris12 added 1-api-auth API & Authentication subsystem skip-openshift-tests labels Jul 22, 2021
@cdchris12 cdchris12 self-assigned this Jul 22, 2021
@cdchris12 cdchris12 added this to the v2.0.0 milestone Jul 22, 2021
@bomoko bomoko merged commit 257f9a0 into main Aug 20, 2021
@tobybellwood tobybellwood deleted the double_dash_project_names branch August 20, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketeerbkw rocketeerbkw Awaiting requested review from rocketeerbkw

Assignees

@cdchris12 cdchris12

Labels
1-api-auth API & Authentication subsystem
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Project names containing -- cause Harbor account creation to fail
2 participants
@cdchris12 @bomoko