Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset exists check at the end of the loop #3543

Merged
merged 1 commit into from Sep 10, 2023

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

There was a condition where the user already exists check resulted in the true statement being retained, preventing new users that aren't already counted from being counted.

This fixes it by resetting the exists check at the end of the user loop check

@shreddedbacon shreddedbacon marked this pull request as ready for review September 10, 2023 22:49
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@tobybellwood tobybellwood merged commit 6734893 into main Sep 10, 2023
1 check passed
@tobybellwood tobybellwood deleted the fix-user-exists-check branch September 10, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants