Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retrieve the restored file size for backups #3599

Merged
merged 1 commit into from Nov 26, 2023
Merged

feat: retrieve the restored file size for backups #3599

merged 1 commit into from Nov 26, 2023

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Just a refactor to the restore query that adds the field restoreSize: Int that reports the ContentLength of the file, which is reported by the S3 client when the HEAD request to check the file exists is executed.

This would allow for the button in the UI to display the size of the file
image

Closing issues

partially #3152 (only for retrieved backups, not all)

@shreddedbacon shreddedbacon mentioned this pull request Nov 19, 2023
Merged
@shreddedbacon shreddedbacon marked this pull request as ready for review November 26, 2023 20:37
@shreddedbacon shreddedbacon added this to the 2.16.1 milestone Nov 26, 2023
tobybellwood
tobybellwood approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, tested fine on MinIO

@tobybellwood tobybellwood merged commit 9476e37 into main Nov 26, 2023
1 check passed
@tobybellwood tobybellwood deleted the restore-size branch November 26, 2023 23:00
@rocketeerbkw rocketeerbkw mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreddedbacon @tobybellwood