Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return error when no matching event to prevent empty email notifications #3637

Merged
merged 1 commit into from Jan 11, 2024
Merged

fix: return error when no matching event to prevent empty email notifications #3637

merged 1 commit into from Jan 11, 2024

Conversation

shreddedbacon
Copy link
Member

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Just a fix for the email notification handler to prevent empty email notifications from being sent when no matching event type is found.

@shreddedbacon shreddedbacon marked this pull request as ready for review January 11, 2024 01:42
bomoko
bomoko approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - in these fall through cases the client code will now not send an email - which is the desired behavior.

LGTM

@shreddedbacon shreddedbacon merged commit 63b8d2b into main Jan 11, 2024
1 check passed
@shreddedbacon shreddedbacon deleted the empty-notifications branch January 11, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomoko bomoko bomoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreddedbacon @bomoko