fix: add DropUnique to rollback ES migration #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
fix-env-services-drop-index
branch
from
88f33f8
to
20e2fca
Compare
tobybellwood
commented
Feb 13, 2024
services/api/database/migrations/20240114000000_environment_services.js
Outdated
Show resolved
Hide resolved
tobybellwood
commented
Feb 13, 2024
services/api/database/migrations/20240114000000_environment_services.js
Outdated
Show resolved
Hide resolved
tobybellwood
commented
Feb 13, 2024
services/api/database/migrations/20240114000000_environment_services.js
Outdated
Show resolved
Hide resolved
shreddedbacon
force-pushed
the
fix-env-services-drop-index
branch
from
20e2fca
to
7cf8427
Compare
shreddedbacon
force-pushed
the
fix-env-services-drop-index
branch
from
7cf8427
to
3e1c266
Compare
|
Merging as reviewed and functional tested by @tobybellwood and @shreddedbacon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3641 additional tables, fields and indexes were added to show environment<>service connections. In the rollback migration, an index was missed for removal. This PR resolves that. It doesn't need a seperate migration, as it hasn't been released yet, and would only be encountered on a rollback.
This PR also adds a github action test designed to try and catch any rollback/migration errors at the point of initial commit. It shouldn't fire without a migration present.
In the development of this PR, it was discovered that migrations could fail if there were multiple services in the same environment with the same "name". As this name is not descriptive (nor unique), the migration now adds a functionality to remove any duplicate service names. With the advent of the build deploy and remote controller changes, it will become impossible for an environment to have multiple identically named services (as it is a docker compose constraint).