Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change default quotas to unlimited for organizations #3720

Merged
merged 3 commits into from May 14, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented May 7, 2024

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Just changes the route quota default to be unlimited by default.

This is mainly because currently the route quota can only be enforced per environment by the build process. With the default being 5, any builds would fail regularly if an environment has more than 5 routes, so when an organization is created, this consideration needs to be made.

Since most people probably wouldn't be doing any route enforcement, it makes more sense for now to make it unlimited and it can be used as required until a better solution can be found (routes in the API, other...)

Updated to include all quotas default to unlimited, this way when an organization is created there are no default limitations, but the creator of the organization has some ability to enforce things as required.

Also updated to include a created timestamp on organizations

@shreddedbacon shreddedbacon added this to the 2.19.0 milestone May 7, 2024
@shreddedbacon shreddedbacon requested a review from bomoko May 7, 2024 06:02
@tobybellwood
Copy link
Member

This makes sense.

I was also wondering if we should or could make quota_environment a multiple of quota_project - you could end up creating an org with less envs than project limits.

@shreddedbacon
Copy link
Member Author

This makes sense.

I was also wondering if we should or could make quota_environment a multiple of quota_project - you could end up creating an org with less envs than project limits.

Yeah, I've thought about this too. But then I get into the "what if one project needs a higher env quota than another project?" and it just becomes a more complex quota solution.

Something like default is quota_environment is per project, rather than overall. But then the ability to define quota overrides for specific things, similar to how deploytargetconfigs works. This way we could implement in a future step without breaking the current quota mechanisms that may suit majority of organizations.

@shreddedbacon shreddedbacon marked this pull request as ready for review May 7, 2024 06:27
@shreddedbacon
Copy link
Member Author

For now, this PR is just to reset the route quota. We can discuss quota extensions/refactoring in a separate issue

@shreddedbacon shreddedbacon changed the title refactor: change default route quota to unlimited for organizations refactor: change default quotas to unlimited for organizations May 8, 2024
@shreddedbacon
Copy link
Member Author

Updated this to reset all quotas for organizations. We will leave these at unlimited for now, but we will look to explore quota rulesets as a feature in the future for finer control over quotas.

The default quotas will remain as they are for now as limits on overall resources (except routes)

@shreddedbacon
Copy link
Member Author

Another to add a created timestamp on the organization

Copy link
Contributor

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense.

@tobybellwood tobybellwood merged commit 6428639 into main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants