New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deployments from UI and deprecate rest2tasks #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketeerbkw
force-pushed
the
838-trigger-deploys-ui
branch
3 times, most recently
from
March 8, 2019 16:45
1b97b40
to
2852c65
Compare
rocketeerbkw
changed the title
[WIP] Allow deployments from UI and deprecate rest2tasks
Allow deployments from UI and deprecate rest2tasks
Mar 9, 2019
Schnitzel
requested changes
Mar 21, 2019
very nice work! just some small adaptions and unfortunately we have some conflicts now :( |
rocketeerbkw
force-pushed
the
838-trigger-deploys-ui
branch
from
March 27, 2019 17:19
2852c65
to
e9000ce
Compare
I rebased to fix the conflicts, will wait for tests to come back while I test locally. |
All green for me locally |
ugh, another Conflict now :( @rocketeerbkw can you have another look? thank you |
Schnitzel
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
API
New mutations added to the API to trigger deployments. Examples:
In order to facilitate deployments, new information is tracked for environments and is now required when creating/updating them. Example:
UI
Environments that have been configured with deployment information will have a new button on the deployments page to trigger a deploy of the latest code for that environment.
Changelog Entry
Feature - API has new mutations for triggering deployments
Change - API requires new deployment information when creating/updating environments
Improvement - UI can now trigger new deployments for environments (#838)
Change - rest2tasks is deprecated in favor of API
Deployment notes
For existing environments, at lest one deployment must happen via non-ui methods before the "deploy" button will show up in the ui. New environments will get the button immediately.
Closing issues
Closes #838