Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto collapse feature for all memos issue #1463 #1550

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Add auto collapse feature for all memos issue #1463 #1550

merged 3 commits into from
Apr 18, 2023

Conversation

polyeung
Copy link
Contributor

I added a auto collapse switch in preference setting,
image

By switching off, all memos will not collapse. If switching on, all memos that exceed certain words limit will collapse as usual.

@polyeung polyeung requested a review from boojack as a code owner April 16, 2023 18:33
@github-actions
Copy link

github-actions bot commented Apr 16, 2023 •
edited

Uffizzi Preview deployment-22395 was deleted.

@polyeung polyeung mentioned this pull request Apr 16, 2023
Closed
CorrectRoadH
CorrectRoadH requested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@CorrectRoadH CorrectRoadH left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. just there are some eslint errors.

@polyeung
Copy link
Contributor Author

Thanks for your reply! I have sorted out the style check :)

@CorrectRoadH CorrectRoadH self-requested a review April 18, 2023 02:03
CorrectRoadH
CorrectRoadH approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@CorrectRoadH CorrectRoadH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boojack boojack merged commit 685a23b into usememos:main Apr 18, 2023
11 checks passed
@polyeung polyeung mentioned this pull request Apr 18, 2023
Closed
@Zeng1998 Zeng1998 mentioned this pull request May 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorrectRoadH CorrectRoadH CorrectRoadH approved these changes

@boojack boojack Awaiting requested review from boojack boojack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polyeung @CorrectRoadH @boojack