fix: memo content availability for visitor mode #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
|
Hey @boojack , Uffizzi deployment (https://app.uffizzi.com/github.com/usememos/memos/pull/1602) for my previous pull request #1602 resulted in the error caused by the MemoContent component and failed to render. In this pull request i have provided the possible patch for that bug. After reviewing this can you check #1602 too. Thank you. |
boojack
approved these changes
Apr 26, 2023
boojack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoContent being part of "Memo" Component and Memo part of "Explore" page. MemoContent throws error and doesn't render without User states. Since user is "undefined" for visitor mode, destructuring user states to get localSetting is not possible. Hence adding further guard to check for visitorMode and making autoCollapse state "true" by default is the right choice.