Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return pinned status after edit #1629

Merged
merged 9 commits into from
May 9, 2023
Merged

fix: return pinned status after edit #1629

merged 9 commits into from
May 9, 2023

Conversation

CorrectRoadH
Copy link
Contributor

@CorrectRoadH CorrectRoadH commented May 3, 2023 •
edited

resolving #1608

What does the PR do?

add an additional query after PATCH. to query the pinned status and add it to the response value.

@CorrectRoadH CorrectRoadH requested a review from boojack as a code owner May 3, 2023 12:32
@github-actions
Copy link

github-actions bot commented May 3, 2023 •
edited

Uffizzi Ephemeral Environment deployment-24196

☁️ https://app.uffizzi.com/github.com/usememos/memos/pull/1629

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@CorrectRoadH CorrectRoadH marked this pull request as draft May 3, 2023 12:40
@CorrectRoadH CorrectRoadH marked this pull request as ready for review May 3, 2023 12:55
@CorrectRoadH CorrectRoadH marked this pull request as draft May 3, 2023 12:57
@CorrectRoadH CorrectRoadH marked this pull request as ready for review May 3, 2023 12:58
boojack
boojack requested changes May 5, 2023
View reviewed changes
store/memo.go Outdated Show resolved Hide resolved
@CorrectRoadH
Copy link
Contributor Author

@boojack PTAL

@CorrectRoadH CorrectRoadH requested a review from boojack May 6, 2023 00:26
@Issues-translate-bot
Copy link

Issue is not in English. It has been translated automatically.

@boojack ASKED

boojack
boojack approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 700fe6b into usememos:main May 9, 2023
11 checks passed
@CorrectRoadH CorrectRoadH mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CorrectRoadH @Issues-translate-bot @boojack