feat: add max upload size setting to UI & UI improvements #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
development and production environments. Default profile.Data will be set to "C:\ProgramData\memos" on Windows. Folder will be created if it does not exist, as this behavior is expected for Windows applications. System service installation can be achieved with third-party tools, explained in docs/windows-service.md. Not sure if it's worth using https://github.com/kardianos/service to make service support built-in. This could be a nice addition alongside usememos#1583 (add Windows artifacts)
…eat--add-swagger-api-documentation
- Fix local file storage path handling on Windows - Improve Windows dev script
…d-size-setting-to-UI
…oad-size-setting-to-UI
- feat: add max upload size setting to UI - feat: max upload size setting is checked on UI during upload, but also enforced by the server - fix: overflowing mobile layout for Create SSO, Create Storage and other Settings dialogs - feat: add HelpButton component with some links to docs were appropriate - remove LearnMore component in favor of HelpButton - refactor: change some if/else to switch statements - refactor: inline some err == nil checks ! Existing databases without the new setting 'max-upload-size-mib' will show an upload error, but this can be user-fixed by simply setting the value on system settings UI.
|
Uffizzi Preview |
|
As for the question of whether to put this configuration to command args or system settings, I prefer to follow the previous thought that without too many unimportant items in the setting. Of course, it's also acceptable to place it in the system settings. |
|
And please update the icon into a normal size. It's a bit too big. 
|
boojack
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add max upload size setting to UI
feat: max upload size setting is checked on UI during upload, but also enforced by back-end.
feat: add HelpButton component with some links to official docs were appropriate
remove LearnMore component in favor of the much more versatile HelpButton (can show tooltips, links or a dialog)
fix: overflowing mobile layout for Create SSO, Create Storage and other Settings dialogs
refactor (back-end): change some if/else to switch statements
refactor (back-end): inline some err == nil checks
! Existing databases without the new setting 'max-upload-size-mib' will show an upload error, but this can be user-fixed by simply setting the value on system settings UI.
Unfortunately this conflicts with #1640, but I think it's a better approach to edit the upload limit on UI rather than command line.
Closes #1577