Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gen thumbnail while get and improve thumbnail quality #1680

Merged
merged 4 commits into from
May 19, 2023
Merged

Gen thumbnail while get and improve thumbnail quality #1680

merged 4 commits into from
May 19, 2023

Conversation

athurg
Copy link
Contributor

@athurg athurg commented May 19, 2023

This PR has two tasks request by @boojack :

  • Improve the thumbnail quality by using disintegration/imaging for resize image.
  • Auto generate the thumbnail if not exists while GET the thumbnail.

@athurg athurg requested a review from boojack as a code owner May 19, 2023 02:37
@github-actions
Copy link

github-actions bot commented May 19, 2023 •
edited

Uffizzi Preview deployment-25838 was deleted.

boojack
boojack approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 04124a2 into usememos:main May 19, 2023
11 checks passed
@athurg athurg deleted the gen_thumbnail_while_get_and_improve_thumbnail_quality branch May 19, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@athurg @boojack