fix: docker-compose.dev.yaml #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalderto
commented
Jan 2, 2024
| dev-dist |
There was a problem hiding this comment.
Added a newline to the end of the file
nalderto
commented
Jan 2, 2024
| - ./.air/mysql:/var/lib/mysql | ||
| - ./../.air/mysql:/var/lib/mysql | ||
| environment: | ||
| MYSQL_ALLOW_EMPTY_PASSWORD: yes |
There was a problem hiding this comment.
Some env var related to setting the password is required.
boojack
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to configure my development environment, I noticed that the Docker compose file for development was no longer working as expecting, as described by the documentation. This commit moved the
docker-compose.dev.yamlfile into thescriptsdirectory. However, as there are numerous relative paths in the compose file, we need to update those.Additionally, I noticed that the DB container wasn't configured properly and hopefully resolved that.
I can make a follow up PR to the documentation repo once this is merged in.