New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve resource internal_path migrator #2698

Merged

boojack merged 2 commits into usememos:main from lincolnthalles:chore/fix-resource-migrator

Jan 3, 2024

Contributor

lincolnthalles commented Jan 2, 2024

handle mixed path styles
handle Windows paths
add tests
run the migration in a separate goroutine, so server startup doesn't take too long on large databases and/or low-end hardware
log basic post-migration stats like INFO store/migrator.go:52 migrated 34219 local resource paths in 42.8559848s


          chore: improve internal path migrator

5670d1e

- handle mixed path styles
- handle Windows paths
- add tests

lincolnthalles requested a review from boojack as a code owner

January 2, 2024 22:44


          chore: fix goimports error

493332b

boojack approved these changes

View reviewed changes

Collaborator

boojack left a comment

LGTM

boojack merged commit 369b8af into usememos:main

5 checks passed

lincolnthalles deleted the chore/fix-resource-migrator branch

January 14, 2024 17:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment