feat: add a webhook action for deleted memos #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ertuil
changed the title
MehadND
pushed a commit
to MehadND/memos
that referenced
this pull request
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a webhook when the memos are deleted. Currently, the webhooks are only triggered when the memos are created (C) or updated (U). But the webhook for deleting (D) is missing. I think it is better for the webhook to activate for the entire CURD procedures.
I love memos, and use it heavily. However, I need it to send me a notice as a reminder, like issue #858. I realize that this function is in the roadmap, but I cannot wait to have it. As a result, I recently worked on my community tool memos-reminder as a temporary solution. It reads memos using the webhook API, and reads some date/time tags in it, and then sends me reminder emails.
However, I find that the current webhook is not completed, as it will not notify my memos-reminder to delete the related timers when the memos are deleted.