Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable iframe rendering in markdown code block #2799

Merged
merged 2 commits into from Jan 20, 2024

Conversation

MarkRushB
Copy link
Contributor

This PR allows users to set Markdown code blocks as 'iframe' to embed videos or external music links from services like Apple Music or Spotify.

image image

@boojack
Copy link
Collaborator

boojack commented Jan 20, 2024

Please solve the error from linter first.

@MarkRushB
Copy link
Contributor Author

Please solve the error from linter first.

@boojack issue has been fixed

Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@boojack boojack merged commit bd1cf62 into usememos:main Jan 20, 2024
5 checks passed
MehadND pushed a commit to MehadND/memos that referenced this pull request Jan 21, 2024
* enable iframe rendering in code block

* fix eslint issue
@yuboabc
Copy link

yuboabc commented Feb 21, 2024

image

我这里为什么会这样呢. 有一个code的背景和标签

@Issues-translate-bot
Copy link

Issue is not in English. It has been translated automatically.


image

Why is this happening here? There is a code background and label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants