fix: avoid making memos public when disabled #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2814
I am not familiar with golang coding, so please make a double check before merge, especially api v1 version.
After this change, changes to the existing public memos would also be banned in api v2. I don't know if it is in line with the original intent of the public memos (I think the target to disable public memos is to prevent users from causually adding/modifying the content displayed on the public pages).
For api v1, enforce normal user to save as private memo if public memos are disabled, just like CreateMemo.
Besides, I wonder whether the api v1 is deprecated and whether it need updating.