Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-signed URL for S3 storage #2855

Merged
merged 1 commit into from
Jan 29, 2024

Commits on Jan 29, 2024

  1. Adds automatically background refresh of all external links if they a…

    …re belongs to the current blob (S3) storage. The feature is disabled by default in order to keep backward compatibility.
    
    The background go-routine spawns once during startup and periodically signs and updates external links if that links belongs to current S3 storage.
    
    The original idea was to sign external links on-demand, however, with current architecture it will require duplicated code in plenty of places. If do it, the changes will be quite invasive and in the end pointless: I believe, the architecture will be eventually updated to give more scalable way for pluggable storage. For example - Upload/Download interface without hard dependency on external link. There are stubs already, but I don't feel confident enough to change significant part of the application architecture.
    reddec committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    f158b4c View commit details
    Browse the repository at this point in the history