Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: month grouping error in timeline page #2861

Merged
merged 1 commit into from Jan 29, 2024

Conversation

xwjdsh
Copy link
Contributor

@xwjdsh xwjdsh commented Jan 29, 2024

Close #2817


For example, if user in the New York timezone, then new Date('2024-01').getFullYear() returns 2023, we should treat it as UTC time or local time with an offset.

@xwjdsh xwjdsh requested a review from boojack as a code owner January 29, 2024 16:38
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit 50f7f13 into usememos:main Jan 29, 2024
5 checks passed
@xwjdsh xwjdsh deleted the fix/month-group-timeline branch January 30, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline stuck on the year 2023
2 participants