Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add en-GB language #2865

Merged
merged 2 commits into from Jan 30, 2024
Merged

chore: add en-GB language #2865

merged 2 commits into from Jan 30, 2024

Conversation

lincolnthalles
Copy link
Contributor

en-GB is just a copy of en-US, at least for now, but it solves an issue with date format that every now and then some user complain.

en will use the format mm/dd/yyyy, and simply selecting en-GB will format dates as dd/mm/yyyy.

British English
image

English
image

@boojack
Copy link
Collaborator

boojack commented Jan 30, 2024

If the translation of en-GB will be always the same as en, maybe we can do some hacks. https://github.com/usememos/memos/pull/2865/files#diff-69661a91c7ad27e32735ba8890bfe6547e961e462b5ecf7fc7b11f3329701c79R52

@lincolnthalles
Copy link
Contributor Author

lincolnthalles commented Jan 30, 2024

If the translation of en-GB will be always the same as en, maybe we can do some hacks. https://github.com/usememos/memos/pull/2865/files#diff-69661a91c7ad27e32735ba8890bfe6547e961e462b5ecf7fc7b11f3329701c79R52

Not always, as there are a few differences in wording between British English and American English.

But it's possible to simply leave the json empty and rely on the default en fallback provided by the i18next extension, it just works. This also leaves room for updating in wording, if someone think it's worth it.

The fallbacks object doesn't work in this case. The language must be listed in availableLocales to allow user selection.

@boojack boojack merged commit e7d5dfe into usememos:main Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants