Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: displaying archived memos #2933

Merged
merged 2 commits into from Feb 7, 2024

Conversation

Kaz205
Copy link
Contributor

@Kaz205 Kaz205 commented Feb 7, 2024

Details written in the commit message.

Archiving a memo is considered "updating" it, so the time it was
archived will be displayed, instead of the time it was created.
Just like on other pages, add a button to fetch more memos. Otherwise,
the user would only be able to load the latest 10 memos, as defined in
DEFAULT_MEMO_LIMIT.
@Kaz205 Kaz205 requested a review from boojack as a code owner February 7, 2024 09:29
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@boojack boojack changed the title Fix displaying archived memos fix: displaying archived memos Feb 7, 2024
@boojack boojack merged commit 5ac17fc into usememos:main Feb 7, 2024
5 of 6 checks passed
@Kaz205 Kaz205 deleted the fix-displaying-archived-memos branch February 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants