feat: add visibility select in ShareMemoDialog #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojack
reviewed
Feb 9, 2024
Comment on lines
86
to
98
| await memoStore | ||
| .updateMemo( | ||
| { | ||
| id: memo.id, | ||
| visibility: visibility, | ||
| }, | ||
| ["visibility"], | ||
| ) | ||
| .then((newMemo: Memo) => { | ||
| if (newMemo.visibility == visibility) { | ||
| toast.success(t("common.changed")); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Don't need to use then in async/await function.
Suggested change
| await memoStore | |
| .updateMemo( | |
| { | |
| id: memo.id, | |
| visibility: visibility, | |
| }, | |
| ["visibility"], | |
| ) | |
| .then((newMemo: Memo) => { | |
| if (newMemo.visibility == visibility) { | |
| toast.success(t("common.changed")); | |
| } | |
| }); | |
| const updatedMemo = await memoStore | |
| .updateMemo( | |
| { | |
| id: memo.id, | |
| visibility: visibility, | |
| }, | |
| ["visibility"], | |
| ) | |
| .then((newMemo: Memo) => { | |
| if (newMemo.visibility == visibility) { | |
| toast.success(t("common.changed")); | |
| } | |
| }); |
There was a problem hiding this comment.
I force-pushed a new version, please check it.
In ShareMemoDialog, user can change the visibility of the memo, so that the memo can be set to public to be viewed by anyone with the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not familiar with ts/react coding, so please make a double check before merge.
In ShareMemoDialog, user can change the visibility of the memo, so that the memo can be set to public to be viewed by anyone with the link.
related issue: #2868
related pr: #2931