fix: dark mode tag selection and suggestion #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When editing a long memo and editing a tag somewhere where the user has to scroll down to, the tag suggestions would be out of place (too far down) because the scrolling wouldn't be taken into account. Fix: Substract the suggestions div by the scroll amount.
Fixes this issue like this:
1. Text #tag text
^ backspace here
2. Text#tag text
^ space
3. Text #tag text
^ tag suggestion opens
boojack
approved these changes
Feb 26, 2024
boojack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am really enjoying this app so far! This is my first self hosted app and first PR :)
This PR fixes three issues:
1. Correct dark mode highlight color of tag in tag suggestion
2. Fix incorrect position of tag suggestion when editing a memo and the memo is scrollable
3. Fix false trigger of tag suggestion
Fix scenario like the following: