Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duration query string #465

Merged
merged 1 commit into from Nov 14, 2022
Merged

fix: duration query string #465

merged 1 commit into from Nov 14, 2022

Conversation

Zeng1998
Copy link
Contributor

Import qs to parse the query string instead of URLSearchParams which cannot parse the duration object.

Video_20221114153058.mp4
Video_20221114153145.mp4

boojack
boojack approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

boojack
boojack approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@boojack boojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boojack boojack merged commit da80d4e into main Nov 14, 2022
@boojack boojack deleted the fix/duration_query_string branch November 15, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojack boojack boojack approved these changes

@lqwakeup lqwakeup Awaiting requested review from lqwakeup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zeng1998 @boojack