Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

RS-4458 require ruby 2.5 #9

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

jeffbax
Copy link
Collaborator

@jeffbax jeffbax commented Sep 28, 2020

Leaving .ruby-version and the rails app to require 2.5.8 specifically for now... I was tempted to do 2.6.6 (specs passed) but ruby 2.6.x is not mentioned until Rails 5.2

Otherwise:

  • fixes missed rspec deprecations
  • adds some UI credits given our hacking it up at this point
  • drops rails < 4.2.10 (because why not)

- fixes missed rspec deprecations
- adds some UI credits given our hacking it up
- drops rails < 4.2.10
@jeffbax jeffbax requested a review from rsaris September 28, 2020 23:41
Copy link

@rsaris rsaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely can remove the support for pre Rails 4 strong params in the models but that's a bit to unpack today and isn't technically necessary for this.

@rsaris
Copy link

rsaris commented Sep 29, 2020

Will this stop us from patching this if needed? Is there any reason to require 2.5 vs. just setting this repo to use it and assuming it supports it?

@jeffbax
Copy link
Collaborator Author

jeffbax commented Sep 29, 2020

Well, there are actual test breakages between 2.4 and 2.5 from the CSV library, so its a bit of a line in the sand.

In either case, I have the rails app ready for 2.5 already and tested happy path

@jeffbax jeffbax merged commit c01a8e4 into user-interviews Sep 29, 2020
@jeffbax jeffbax deleted the feature/RS-4458-support-ruby-2.5 branch September 29, 2020 00:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants