Delays initialization on React #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On second init, it returns the originally created promise instead of erroring
Shard
approved these changes
Feb 21, 2023
|
Hi @ekwoka, Sorry for the delay on getting this PR moving. I remember reviewing and testing the e2e locally earlier, then trying to get the e2e working for external contributors and getting distracted by life (as always 😄 ). I'm just going to merge it into develop now and make sure its working fine before I look to cut a new release for this 🎉 Cheers again for the contribution 🥇 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a portion of #21
This PR:
initusing a store promise, allowing multiple calls to init to load only one instance while still having both "succeed" safelyI couldn't get tests to work at all locally (not entirely sure the steps needed to even run them as the readme seemed incomplete) so those will need to be checked, and possibly additional tests added for this.