UF 4.2.1 DefaultPermissions seed results in SQL errors

[noellekimiko]

UserFrosting Forum thread: https://forums.userfrosting.com/t/defaultpermissions-seed-doesnt-run/543

The Permission class doesn't have an id property, so the database calls in the syncPermissionsRole() function actually result in SQL errors because the permission_id is not defined.

I was able to run it by adding this code to the top of the syncPermissionsRole() function:

$permissionIds = [];
        foreach ($permissions as $slug => $permission) {
            $permissionIds[$slug] = Permission::where(['slug' => $permission->slug, 'conditions' => $permission->conditions])->first()->id;
        }

and then changing the various $permissions['PERMISSION_NAME']->id calls to be $permissionIds['PERMISSION_NAME'].

[lcharette]

This solution is not perfect as it requires an additional db query. The id is actually generated when save is executed.

The real problem is $permissions here is not changed by the actions in savePermissions. A more simple fix would probably be to pass the variable by reference here:

protected function savePermissions(array &$permissions)

[amosfolz]

This looks like something within my skill set. I will work on it this weekend if no one else gets to it before then.