Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception handling isn't working correctly #21

Closed
Silic0nS0ldier opened this issue Feb 6, 2019 · 0 comments
Closed

Exception handling isn't working correctly #21

Silic0nS0ldier opened this issue Feb 6, 2019 · 0 comments
Assignees
@Silic0nS0ldier
Labels
bug Issue is a confirmed bug.

Comments

@Silic0nS0ldier
Copy link
Member

Exceptions in bundle factory streams and internal components are not getting hoisted and emitted by the top level bundler. Not sure about the consequences of this, however in testing it results in hanging of the test case.
@Silic0nS0ldier Silic0nS0ldier added the bug Issue is a confirmed bug. label Feb 6, 2019
@Silic0nS0ldier Silic0nS0ldier self-assigned this Feb 6, 2019
Silic0nS0ldier added a commit that referenced this issue Feb 6, 2019
@Silic0nS0ldier
#8
a0edf44 
- Fixed #21
- Improved test coverage of `main.ts`
Silic0nS0ldier added a commit that referenced this issue Feb 7, 2019
@Silic0nS0ldier
#21 Only run fix if its needed
41ce86e
Silic0nS0ldier added a commit that referenced this issue Feb 10, 2019
@Silic0nS0ldier
100% Test Coverage (#19)
121a3d8 
* #8 Fleshed out unit tests, achieving 100% coverage
* Revised unit test names and added comments to define a rough spec
* Ignored difficult to reproduce failure recovery code from code coverage
* Removed unnecessary checks from internal class `BundleSource`
* Separated merge and validation logic into multiple files to improve maintainability
* Fixed error in duplicate detection logic of config validation
* #21 Fixed issue where a hang could occur due to a paused internal stream
* #22 Fixed flaw in results callback data collection where styles would replace styles within the same bundle
* Improved logging, particularly around source identification
* Removed redundant double usage of nyc test coverage wrapper
* Updated `CHANGELOG.md` and `README.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Silic0nS0ldier Silic0nS0ldier

Labels
bug Issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Silic0nS0ldier