Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flesh out unit tests #8

Closed
Silic0nS0ldier opened this issue Nov 17, 2018 · 1 comment
Closed

Flesh out unit tests #8

Silic0nS0ldier opened this issue Nov 17, 2018 · 1 comment
Assignees
@Silic0nS0ldier
Milestone
patch

Comments

@Silic0nS0ldier
Copy link
Member

Most of the lower level functions are fully covered, however the more complex areas need to be covered further. Specifically the components that utilise streams.
@Silic0nS0ldier Silic0nS0ldier added this to the 3.0.0 milestone Nov 17, 2018
@Silic0nS0ldier Silic0nS0ldier modified the milestones: 3.0.0, patch Jan 9, 2019
@Silic0nS0ldier
Copy link
Member Author

Silic0nS0ldier added a commit that referenced this issue Jan 31, 2019
@Silic0nS0ldier
#8 Improved test coverage for BundlesProcessor and misc. fixes
274b540
Silic0nS0ldier added a commit that referenced this issue Jan 31, 2019
@Silic0nS0ldier
#8 Remove unneeded checks (internal class, guarded by design)
2b4c2c3
Silic0nS0ldier added a commit that referenced this issue Jan 31, 2019
@Silic0nS0ldier
#8 More test coverage for bundles-processor
37727e9
Silic0nS0ldier added a commit that referenced this issue Jan 31, 2019
@Silic0nS0ldier
#8 Ignore code that only runs by chance of runtime status in catcher
0f2faf5
@Silic0nS0ldier Silic0nS0ldier self-assigned this Jan 31, 2019
Silic0nS0ldier added a commit that referenced this issue Feb 4, 2019
@Silic0nS0ldier
#8 Test coverage improvements
b489dcf 
- Factored merge logic into multiple files for improved maintainability
- Improve test coverage across multiple components
- Renamed many test names to improve usefulness
Silic0nS0ldier added a commit that referenced this issue Feb 4, 2019
@Silic0nS0ldier
#8 Improve merge bundle test coverage
c3b9ef0
Silic0nS0ldier added a commit that referenced this issue Feb 4, 2019
@Silic0nS0ldier
#8 Improve test coverage for merge-configs
66f0ab5
Silic0nS0ldier added a commit that referenced this issue Feb 5, 2019
@Silic0nS0ldier
#8
2f86a46 
- Improved test coverage of validate config
- Fixed duplicate detection in validate config
- Updated changelog
Silic0nS0ldier added a commit that referenced this issue Feb 5, 2019
@Silic0nS0ldier
#8 Last line of validate config (test coverage)
49225a4
Silic0nS0ldier added a commit that referenced this issue Feb 5, 2019
@Silic0nS0ldier
#8 Last line for validate bundle (test coverage)
e2985a5
Silic0nS0ldier added a commit that referenced this issue Feb 6, 2019
@Silic0nS0ldier
#8
a0edf44 
- Fixed #21
- Improved test coverage of `main.ts`
Silic0nS0ldier added a commit that referenced this issue Feb 7, 2019
@Silic0nS0ldier
#8
9d53d61 
- Additional (rough) coverage for main.
- Improved logging ownership.
Silic0nS0ldier added a commit that referenced this issue Feb 7, 2019
@Silic0nS0ldier
- #8 Super rough test improvements for main
ff9cfad 
- #22 Backwards compatible fix for overwriting of results callback data
Silic0nS0ldier added a commit that referenced this issue Feb 7, 2019
@Silic0nS0ldier
#8 Improve coverage of main
b27bdf0
Silic0nS0ldier added a commit that referenced this issue Feb 7, 2019
@Silic0nS0ldier
#8 Attempt at hitting 100% one
8cfcc4e
Silic0nS0ldier added a commit that referenced this issue Feb 10, 2019
@Silic0nS0ldier
100% Test Coverage (#19)
121a3d8 
* #8 Fleshed out unit tests, achieving 100% coverage
* Revised unit test names and added comments to define a rough spec
* Ignored difficult to reproduce failure recovery code from code coverage
* Removed unnecessary checks from internal class `BundleSource`
* Separated merge and validation logic into multiple files to improve maintainability
* Fixed error in duplicate detection logic of config validation
* #21 Fixed issue where a hang could occur due to a paused internal stream
* #22 Fixed flaw in results callback data collection where styles would replace styles within the same bundle
* Improved logging, particularly around source identification
* Removed redundant double usage of nyc test coverage wrapper
* Updated `CHANGELOG.md` and `README.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Silic0nS0ldier Silic0nS0ldier

Labels
None yet
Projects
None yet
Milestone
patch
Development

No branches or pull requests
1 participant
@Silic0nS0ldier