Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codicon suggest] Align all icon positioning #46

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Mar 9, 2023

Hi! I also had a similar extension to command to copy codicon into clipboard, but I was always too lazy to set up auto-updating codicons on CI, so would be happy to use your command instead. But for now icons are positioned at the end of quick pick and thus its harder to search through them, I don't see anything bad in positioning them at the start instead. I believe this is what most users expect: for example all "native quickpicks" such as workbench.action.quickOpen also position file icon at the start, so IMO icon should be always positioned at the start without any exceptions (I believe it was even in vscode guidelines).

@zardoy
Copy link
Contributor Author

zardoy commented Mar 9, 2023

Btw I saw you store a copy of commands args schema, but why don't you access it in runtime instead? eg

const commandsSchema = (await vscode.workspace.openTextDocument('vscode://schemas/keybindings')).getText()

@usernamehw usernamehw merged commit 448e6c7 into usernamehw:master Mar 9, 2023
@usernamehw
Copy link
Owner

I didn't know that it was possible. Can you show how to apply it?

@zardoy
Copy link
Contributor Author

zardoy commented Mar 15, 2023

I didn't know that it was possible. Can you show how to apply it?

https://github.com/zardoy/extra-commands/blob/46fe01c2091d970fbe65c7c5ad2f1ad99e547389/src/platformKeybindings.ts#L23-L51

@zardoy zardoy deleted the codicon-better-icon branch March 16, 2023 21:39
@usernamehw
Copy link
Owner

Better than it was now: 28657b8

They are duplicated, but all names work and people can think of it as aliases, I guess:

zardoy added a commit to zardoy/vscode-experiments that referenced this pull request Mar 17, 2023
@zardoy
Copy link
Contributor Author

zardoy commented Mar 17, 2023

I saw how you applied this idea of generating dynamic JSON schema 👏. Now I think its one of the most advanced extension I've seen on marketplace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants