fix(models): resolve a bug with UpdateOAuth query

userstyles-world · May 29, 2021 · e024042 · e024042
1 parent b39ae38
commit e024042
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/handlers/oauthProvider/oauth_settings.go b/handlers/oauthProvider/oauth_settings.go
@@ -122,7 +122,7 @@ func OAuthSettingsPost(c *fiber.Ctx) error {
 
 	var err error
 	if id != "" {
-		err = models.UpdateOAuth(database.DB, &q)
+		err = models.UpdateOAuth(database.DB, &q, id)
 	} else {
 		q.ClientID = utils.UnsafeString((utils.RandStringBytesMaskImprSrcUnsafe(32)))
 		q.ClientSecret = utils.UnsafeString((utils.RandStringBytesMaskImprSrcUnsafe(128)))

diff --git a/models/oauth.go b/models/oauth.go
@@ -120,6 +120,7 @@ func GetOAuthByClientID(db *gorm.DB, clientID string) (*APIOAuth, error) {
 
 func CreateOAuth(db *gorm.DB, o *OAuth) (*OAuth, error) {
 	err := getDBSession(db).
+		Debug().
 		Create(&o).
 		Error
 	if err != nil {
@@ -129,11 +130,11 @@ func CreateOAuth(db *gorm.DB, o *OAuth) (*OAuth, error) {
 	return o, nil
 }
 
-func UpdateOAuth(db *gorm.DB, o *OAuth) error {
+func UpdateOAuth(db *gorm.DB, o *OAuth, id string) error {
 	err := getDBSession(db).
 		Debug().
 		Model(OAuth{}).
-		Where("id", o.ID).
+		Where("id = ?", id).
 		Updates(o).
 		Error
 	if err != nil {